Reject incompatible slf4j-api versions from Slf4j implementations #123
Conversation
There was a problem hiding this comment.
I haven't added tests yet (only changed a couple to make the pass), happy to discuss what should be done here (migrate everything to Slf4j 2 then add a test for the 1 vs 2 incompatibility?)
I think the approach might have to be discussed too before I spend more time on it (and then other PRs that will require Slf4j 2, e.g. for slf4j-jdk-platform-logging, or just an updated Slf4j, e.g. slf4j-reload4j).
| @@ -0,0 +1,85 @@ | |||
| /* | |||
| * Copyright the GradleX team. | |||
There was a problem hiding this comment.
Checkstyle currently requires that line, but I don't think this is how things work or should work, as:
- I'm not part of the Gradlex team
- you don't have any contributor agreement that I know of that would require copyright reassignment
| protected void additionalAdjustments(ModuleVersionIdentifier id, VariantMetadata variant) { | ||
| additionalAdjustments(variant); | ||
| } |
There was a problem hiding this comment.
Should this replace the overloaded method? I don't thing this should be considered a public API so introducing a breaking change like that could be acceptable.
jjohannes
added
a:rule
2 participants
Fixes #122